My first pull request got rejected 14 times in one afternoon

Honestly, I thought I was being helpful by fixing a typo in some documentation. But the maintainer kept asking me to change the indentation from spaces to tabs, then tabs back to spaces, and I just sat there at my desk in Seattle refreshing the page for 3 hours. Has anyone else had a simple fix turn into a whole ordeal like that?

2 comments

2 Comments

ryang6513d ago

Did he at least buy you dinner after all that back and forth? Man that reminds me of the time I tried to update a readme file for a little side project I found on GitHub. I just wanted to add a note about a bug I ran into, nothing fancy. The maintainer responded within like five minutes asking me to change the whole structure of my commit message. Went from "fixed minor typo" to a whole paragraph with a numbered list and everything. I spent more time rewriting that message than I did actually finding and fixing the issue. Honestly felt like I was filling out a tax form or something.

maxmurphy13d ago

Jumping in as devil's advocate here @ryang65, but those structured commit messages actually save time in the long run when you're trying to figure out what broke six months later. A little extra formatting upfront beats hunting through vague notes any day.